xls icon indicating copy to clipboard operation
xls copied to clipboard
verified publisher icon google

Map channels to nodes in package

Open meheff opened this issue 4 years ago • 2 comments

Currently there is no mapping from channel to nodes in an IR package. This makes it awkward, for exmaple, to find the send/receive node assocated with a channel. We should add such a map. The downside is the necessity of keeping the map up to date as send/receive nodes are added/removed from the graph.

meheff avatar Apr 27 '21 17:04 meheff

We do have a similar mapping for register -> registerWrite/Read nodes. This is maintained by code in Block::AddRegister and BlockRemove and overrides of AddNode and RemoveNode. However the channel map is a bit more complicated. Channels are package scoped, but the nodes are functionbase-scoped. This means that the mapping may be modified when nodes are added/removed from the graph AND when functionbases are added/removed from the package. The latter occurs, for example, in FunctionBuilder::Build.

meheff avatar Mar 15 '22 21:03 meheff

@hongted

meheff avatar Mar 15 '22 21:03 meheff

Marking as "long term enhancement" because I believe there's not a pressing need to have this association today.

cdleary avatar Nov 01 '22 18:11 cdleary