xls icon indicating copy to clipboard operation
xls copied to clipboard

`dslx_jit_wrapper` needs to anonymous namespace ir_text to avoid ODR violations?

Open cdleary opened this issue 3 years ago • 1 comments

Noticed the source files all have ir_text[] in the xls namespace -- even though it's constexpr char char ir_text[] still can cause ODR violations I presume (and these I imagine would be confusing since we'd JIT the wrong thing)?

cdleary avatar Apr 22 '21 07:04 cdleary

Related issue: https://github.com/google/xls/issues/733

I'm guessing this issue can be fixed by putting ir_text into an anonymous namespace.

meheff avatar Oct 04 '22 20:10 meheff