wire icon indicating copy to clipboard operation
wire copied to clipboard

[Feat] [Issue-185] do not use global variables for all wire.Value expressions

Open ProgrammingMuffin opened this issue 2 years ago • 3 comments

Fixes Issue-185

Previously, wire used to generate global variables and inject them in place of wire.Value(..) but now it won't create global variables at all and instead puts the value directly from source.

Source: image

Generated: image

ProgrammingMuffin avatar Dec 15 '23 14:12 ProgrammingMuffin

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Dec 15 '23 14:12 google-cla[bot]

testdata/VarValue fails due to program output related problems.

This might be that one edge case where the replaced value is wrong.

ProgrammingMuffin avatar Dec 15 '23 18:12 ProgrammingMuffin

@zombiezen could you please take a look at this PR? Thank you

ProgrammingMuffin avatar Feb 26 '24 17:02 ProgrammingMuffin