wire icon indicating copy to clipboard operation
wire copied to clipboard

Update record/replay files for Go 1.18

Open anthonyfok opened this issue 3 years ago • 3 comments

This fixes error message mismatch in InterfaceBindingNotEnoughArgs and InterfaceValueNotEnoughArgs with Go 1.18.

The Go version in tests.yml GitHub workflow is updated accordingly.

Fixes #355

anthonyfok avatar Apr 12 '22 13:04 anthonyfok

Shouldn't the test matrix cover the two supported versions, currently 1.17 and 1.18 ?

fgm avatar Apr 12 '22 19:04 fgm

Shouldn't the test matrix cover the two supported versions, currently 1.17 and 1.18 ?

Well, the test matrix currently covers only 1.17.x and not 1.16.x, and unless the current way of testing (direct comparison of generated files) is changed, there is no way we can cover two versions simultaneously when their generated outputs differ.

anthonyfok avatar May 30 '22 15:05 anthonyfok

Do we decide to merge this? Because Go lang already reach version 1.20.3

giautm avatar Apr 21 '23 12:04 giautm