wire icon indicating copy to clipboard operation
wire copied to clipboard

internal/wire: supported a new build constraints

Open Code-Hex opened this issue 4 years ago • 6 comments

The go command now understands //go:build lines and prefers them over // +build lines. As the link says, Go Team has a migration plan. So I fixed it so that it is supported by auto-generation. https://tip.golang.org/doc/go1.17#:~:text=mod%20download%20all.-,//go%3Abuild%20lines,-The%20go%20command

Code-Hex avatar Oct 07 '21 08:10 Code-Hex

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Oct 07 '21 08:10 google-cla[bot]

@googlebot I signed it!

Code-Hex avatar Oct 07 '21 08:10 Code-Hex

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Oct 13 '21 09:10 google-cla[bot]

@googlebot I fixed it.

Code-Hex avatar Oct 13 '21 09:10 Code-Hex

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Oct 13 '21 09:10 google-cla[bot]

This new check was added after 1.17.3 i guess, i think you also need to validate with go version before adding the new constraint for backward compatibility.

utkarshmani1997 avatar Jan 06 '22 07:01 utkarshmani1997