weather-tools icon indicating copy to clipboard operation
weather-tools copied to clipboard

Replace deprecated command with environment file

Open jongwooo opened this issue 2 years ago • 2 comments

Description

Resolve #320

Update .github/workflows/ci.yml to use environment file instead of deprecated set-output command. For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow file that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

echo "::set-output name=dir::$(pip cache dir)"

TO-BE

echo "dir=$(pip cache dir)" >> $GITHUB_OUTPUT

jongwooo avatar Apr 22 '23 15:04 jongwooo

This looks pretty good to me. Can you make sure that the 3.8 CI passes before me merge this?

alxmrs avatar Jul 21 '23 04:07 alxmrs

@alxmrs I've tried force-push. If that fails, I'll change this PR to draft and try to fix it😅

jongwooo avatar Jul 21 '23 04:07 jongwooo