wasefire icon indicating copy to clipboard operation
wasefire copied to clipboard

WIP Add ctap hid api

Open kofls opened this issue 1 year ago • 4 comments

kofls avatar Jul 22 '24 15:07 kofls

This is a draft PR for the CTAP HID api. I still have to implement the actual read/write using the usbd-ctaphid crate. Just wanted to get initial feedback on the approach.

I'm copying the read/write signatures we have in the usb-serial API currently. Do we also want to have the asynchronous reads/writes like we have in the usb serial api?

kofls avatar Jul 22 '24 15:07 kofls

ccing @kaczmarczyck who might also have ideas on how to implement the authenticator side of CTAP2

ia0 avatar Aug 13 '24 11:08 ia0

ccing @kaczmarczyck who might also have ideas on how to implement the authenticator side of CTAP2

I assume you mean CTAP HID instead of CTAP2? And you need descriptors etc? OpenSK has this for Tock:

https://github.com/google/OpenSK/blob/2.1/patches/tock/03-add-ctap-modules.patch

kaczmarczyck avatar Aug 14 '24 15:08 kaczmarczyck

I assume you mean CTAP HID instead of CTAP2?

Yes

And you need descriptors etc?

Not necessarily. It depends on the crate. I guess the HID crate would provide some support for the report. And the USB crate definitely provided support for descriptors.

(By the way, the code you reviewed was copy-pasted and will probably not make it to the end.)

ia0 avatar Aug 14 '24 15:08 ia0

Closing this in favor of #734 and its follow-ups (most probably using usbd-hid, or possibly usbd-human-interface-device).

ia0 avatar Feb 12 '25 09:02 ia0