vulkan-performance-layers icon indicating copy to clipboard operation
vulkan-performance-layers copied to clipboard

Remove all Abseil dependencies

Open kuhar opened this issue 4 years ago • 3 comments
trafficstars

We cannot use Abseil in dynamically loaded and dynamically unloaded libraries: https://abseil.io/about/compatibility#what-users-must-and-must-not-do

Dynamic unloading of performance layers causes crashes because of Abseil code.

kuhar avatar Sep 30 '21 20:09 kuhar

Hello @kuhar ,please are we to remove these lines of code ?

https://github.com/google/vulkan-performance-layers/blob/1571ee5af43a0a1c71694531777c1179530e0f63/.gitmodules#L1-L3

https://github.com/google/vulkan-performance-layers/blob/1571ee5af43a0a1c71694531777c1179530e0f63/CMakeLists.txt#L27-L28

https://github.com/google/vulkan-performance-layers/blob/1571ee5af43a0a1c71694531777c1179530e0f63/third_party/CMakeLists.txt#L16

Forchapeatl avatar Nov 03 '22 07:11 Forchapeatl

Yes, but we also need to remove any code that uses the abeil libraries and replace it with some combination of the c++ standard library, new hand-rolled counterparts, or possibly some alternative third-party library. The existing abseil code is easy to spot because it starts with absl:: and ABSL_.

kuhar avatar Nov 03 '22 14:11 kuhar

Thank you @kuhar

and replace it with some combination of the c++ standard library, new hand-rolled counterparts, or possibly some alternative third-party library.

Please do we have a replacement library , should I comment out the abseil code or do i just remove the abseil related code ?

Forchapeatl avatar Nov 03 '22 15:11 Forchapeatl