vulkan-performance-layers icon indicating copy to clipboard operation
vulkan-performance-layers copied to clipboard

Published 20 hours ago • verified publisher icon google

Allow to use libc++ in CMake builds

Open kuhar opened this issue 4 years ago • 4 comments
trafficstars

The filesystem library is hardcoded as the libstdc++ one:

set(FILESYSTEM_LIB_NAME stdc++fs)

kuhar avatar Sep 29 '21 21:09 kuhar

Hello @kuhar , please may I take this issue ?

Forchapeatl avatar Nov 02 '22 20:11 Forchapeatl

@Forchapeatl Sure! Let me know if you have any questions.

kuhar avatar Nov 02 '22 20:11 kuhar

Please it seems like there issue was solved 9 days ago. Is there any thing else I could help with?

https://github.com/google/vulkan-performance-layers/blob/1571ee5af43a0a1c71694531777c1179530e0f63/CMakeLists.txt#L25

Forchapeatl avatar Nov 02 '22 20:11 Forchapeatl

This part of the CMake file hasn't changed in about a year. Currently, we use stdc++fs unconditionally, even when the prefered one is different (libstd++ vs. libc++).

Related discussion:

  • https://gitlab.kitware.com/cmake/cmake/-/issues/17834
  • https://discourse.cmake.org/t/find-library-does-not-find-stdc-fs/4764

kuhar avatar Nov 02 '22 20:11 kuhar