vim-maktaba icon indicating copy to clipboard operation
vim-maktaba copied to clipboard

Remove env_dict param from Syscall.CallAsync callbacks

Open dbarnett opened this issue 8 years ago • 1 comments

Syscall.CallAsync expects a callback with signature callback({env_dict}, {result_dict}), where env_dict contains cursor and vim state info. In practice, it's not easy to remember the argument order, and it's easy enough and more explicit/flexible for the caller to just capture the env info they need and bind it to the callback with maktaba#function#Create.

We should migrate Syscall.CallAsync to expect a signature callback({result_dict}) instead and just document how callers can capture and pass info along.

dbarnett avatar Mar 20 '17 00:03 dbarnett

Reopening to track cleanup. We should change it to shout an error after a couple weeks, and then remove it entirely about a month after that.

dbarnett avatar Mar 21 '17 17:03 dbarnett