uncertainty-baselines icon indicating copy to clipboard operation
uncertainty-baselines copied to clipboard

Performance issue in baselines/cifar/ (by P3)

Open DLPerf opened this issue 4 years ago • 1 comments

Hello! I've found a performance issue in utils.py /: dataset.batch(batch_size, drop_remainder=drop_remainder)(here) should be called before dataset.map(preprocess, num_parallel_calls=tf.data.experimental.AUTOTUNE)(here), which could make your program more efficient.

Here is the tensorflow document to support it.

Besides, you need to check the function preprocess called in dataset.map(preprocess, num_parallel_calls=tf.data.experimental.AUTOTUNE) whether to be affected or not to make the changed code work properly. For example, if preprocess needs data with shape (x, y, z) as its input before fix, it would require data with shape (batch_size, x, y, z) after fix.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

DLPerf avatar Aug 30 '21 10:08 DLPerf

Hello, I'm looking forward to your reply~

DLPerf avatar Nov 04 '21 09:11 DLPerf