turbinia icon indicating copy to clipboard operation
turbinia copied to clipboard

Fix dump_json and make cli parameters consistent.

Open hacktobeer opened this issue 4 years ago • 2 comments

  • dump_json outputs valid JSON
  • CLI parameter --dump_json can be used consistently across all supported commands.
  • request, requests, statistics, status and workers commands are now supported.

$ turbiniactl --dump_json -a status -r [request id] $ turbiniactl --dump_json -a status -w $ turbiniactl --dump_json -a status -i $ turbiniactl --dump_json -a status -s $ turbiniactl --dump_json compressedfolder -l /evidece/folder.zip (or any other request creation)

The option --dump_json that only would dump the request and would do nothing else has been removed.

Fixes #712

hacktobeer avatar Feb 04 '21 14:02 hacktobeer

PTAL

hacktobeer avatar Feb 17 '21 14:02 hacktobeer

Got some more ideas on how to make this better. Moving to Draft.

hacktobeer avatar Feb 18 '21 16:02 hacktobeer

@hacktobeer I believe this is now addressed via the new turbinia cli tool that uses the API server to dump json data. The output should be consistent. Let me know if there is something from this PR that you'd like to add to the new client or if we can close this.

jleaniz avatar Jan 10 '23 16:01 jleaniz

Given the comment above, I'll close this for now and we can always re-open it if needed.

aarontp avatar Jan 13 '23 00:01 aarontp