turbinia icon indicating copy to clipboard operation
turbinia copied to clipboard

Fixed EWF support

Open Slaynot opened this issue 1 year ago • 4 comments

Description of the change

  • Added back ewfmount command in worker docker
  • Added tests for EWF support. Test data was taken from https://github.com/log2timeline/dfvfs/tree/main/test_data as advised in #1116

Applicable issues

  • #1437
  • #1116

Additional information

The bug was introduced in the worker Dockerfile in 3450b2d.

Checklist

  • [ x] All tests were successful.
  • [ x] Unit tests added.

Slaynot avatar Feb 18 '24 21:02 Slaynot

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Feb 18 '24 21:02 google-cla[bot]

Hi @Slaynot - thanks for the contribution. Could you please sign the CLA for us to be able to merge these changes?

jleaniz avatar Feb 19 '24 15:02 jleaniz

I did, the check seems to not work as the email associated with the commits is not the same as the one used to sign the CLA. Not too sure what I can do about that.

Slaynot avatar Feb 19 '24 17:02 Slaynot

@aarontp do you know how to fix the CLA issue without having to reopen the PR?

jleaniz avatar Feb 19 '24 20:02 jleaniz

I'm not sure if we can retrigger this with another email address, but I'll look into that.

aarontp avatar Feb 21 '24 08:02 aarontp

@Slaynot if you want to expedite this being merged, it's probably best to reopen the PR and make sure all commits use the same user/email you signed the CLA with.

jleaniz avatar Feb 21 '24 17:02 jleaniz