turbinia icon indicating copy to clipboard operation
turbinia copied to clipboard

Rewrite pinfo.py call

Open hacktobeer opened this issue 1 year ago • 4 comments

Description of the change

Rewrite the call to pinfo.py from a sys call to a pinfo lib call to prevent issues with parsing the json output.

Applicable issues

  • fixes #

Checklist

  • [ ] All tests were successful.
  • [ ] Unit tests added.

hacktobeer avatar Jan 25 '24 08:01 hacktobeer

This of course needs the python plaso libs which we do not install. I am going to park this PR until @jleaniz is back and we moved back to GIFT-PPA.

hacktobeer avatar Jan 25 '24 08:01 hacktobeer

@hacktobeer the tests actually pass, but i think you need to merge with the master branch for some updates to the docs (doc building failed)

jleaniz avatar Feb 15 '24 17:02 jleaniz

Never mind, i see what you mean

ModuleNotFoundError: No module named 'plaso'

jleaniz avatar Feb 15 '24 17:02 jleaniz

I wonder why this isn't available since poetry installs the plaso python package?

**#33 395.0   • Installing plaso (20230717)**

jleaniz avatar Feb 15 '24 17:02 jleaniz

This has been fixed in another PR without using the plaso python lib but does parse the json taking into account possible error messages.

hacktobeer avatar Feb 29 '24 15:02 hacktobeer