turbinia icon indicating copy to clipboard operation
turbinia copied to clipboard

Published 20 hours ago • verified publisher icon google

Implemented ExpertWitnessFormat for disk 2

Open Simon-Berg opened this issue 2 years ago • 1 comments

Hopefully this is as the previous one was. Only difference should be that we fixed formatting using yapf and pulled the newest changes from the main repo.

Simon-Berg avatar Aug 04 '22 06:08 Simon-Berg

I think other than the open thread on for the pre-processor and the tests that this PR LGTM. I understand from our chat out of band that you might not have time to write the tests, so let us know if you want us to take over this or other parts of the PR. Thanks again!

aarontp avatar Aug 08 '22 22:08 aarontp

@aarontp LGTM

dfjxs avatar Aug 11 '22 23:08 dfjxs