truth icon indicating copy to clipboard operation
truth copied to clipboard

Change failure message of StringSubject.matches and add test cases

Open junyan59 opened this issue 3 years ago • 3 comments

Add an additional message to suggest using containsMatch, if matches(x) fails but containsMatch(x) would have passed. Add corresponding test cases. issue link: https://github.com/google/truth/issues/791

junyan59 avatar Mar 01 '21 18:03 junyan59

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Mar 01 '21 18:03 google-cla[bot]

@googlebot I signed it!

junyan59 avatar Mar 01 '21 18:03 junyan59

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Mar 01 '21 18:03 google-cla[bot]