timesketch icon indicating copy to clipboard operation
timesketch copied to clipboard

Increase the story tab content width size to 100% (UI/UX)

Open n0tmyproblem opened this issue 3 years ago • 6 comments

Is your feature request related to a problem? Please describe.

There are unused right screen white space in story content. Idk why is made. Maybe there is a reason I didn't see in blog posts, issues, documentation or CON-talks on YT.

Describe the solution you'd like

Remove the CSS "max-width: 970ch;" attribute in the "markdown-body" class.

Reference

https://github.com/google/timesketch/blob/0ab609426b1c128c63eaff42b5ef83ab3ca6803d/timesketch/frontend/src/views/StoryContent.vue#L269

Example with the proposed change

image

n0tmyproblem avatar May 20 '21 11:05 n0tmyproblem

Hi, thanks for the report. We used to have this set to 100% width but changed this a while back to make the text easier to read (line length). But maybe we should make this optional, and have a toggle to choose? WDYT?

berggren avatar May 21 '21 14:05 berggren

Yep, maybe a Button --> modal with simple check boxes and selects to customize a story

image

It will require to add new text field to "story" table (Postgresql).

image

Maybe a new field "width" and the close values [''narrow', 'full'].

Then add the set/get value in the backend models, send it to the VUE views and trigger this field in the specific story list VUE component.

n0tmyproblem avatar May 27 '21 13:05 n0tmyproblem

@jaegeral Hi Jaegeral! I was checking out this issue just to see how the front end works for this codebase... how do we reflect updates made to the Vue frontend on the development server? I have not been able to figure out how to see changes. Thanks!

ty-labs avatar Dec 01 '21 22:12 ty-labs

@jaegeral Hi Jaegeral! I was checking out this issue just to see how the front end works for this codebase... how do we reflect updates made to the Vue frontend on the development server? I have not been able to figure out how to see changes. Thanks!

Hey, you might want to look at: https://timesketch.org/developers/frontend-development/ that covers how to see your updates in your dev server environment.

jaegeral avatar Dec 02 '21 08:12 jaegeral

@jaegeral I can't believe I missed that :grimacing: thanks!

ty-labs avatar Dec 02 '21 14:12 ty-labs

@jaegeral Hi Jaegeral! I was checking out this issue just to see how the front end works for this codebase... how do we reflect updates made to the Vue frontend on the development server? I have not been able to figure out how to see changes. Thanks!

Hey, you might want to look at: https://timesketch.org/developers/frontend-development/ that covers how to see your updates in your dev server environment.

@jaegeral Sorry but one more follow-up. I assume that the first command "docker-compose exec timesketch yarn install --cwd=/usr/local/src/timesketch/timesketch/frontend" should be run from the directory docker/dev, however, it gives me this error when I attempt to docker-compose (note that the timesketch dev server is running at this point).

image

I'm wondering if I am the only person with this problem, and if not, which file I need to go to to fix this. Thanks!

ty-labs avatar Dec 03 '21 04:12 ty-labs

Closing this out as stories has been ported over to the new UI

berggren avatar Apr 26 '23 07:04 berggren