tf-quant-finance icon indicating copy to clipboard operation
tf-quant-finance copied to clipboard

fix code quality issues

Open withshubh opened this issue 3 years ago • 4 comments

Description

Hi :wave: I work at DeepSource, I ran DeepSource analysis on the forked copy of this repo and found some interesting code quality issues in the codebase, opening this PR so you can assess if our platform is right and helpful for you.

Summary of changes

  • Removed unnecessary use of comprehension …
  • Used literal syntax instead of function calls to create data structure
  • Used callable() to check if the object is calllable
  • Refactored unnecessary else / elif when if block has a break statement
  • Remove implicit object from the base class
  • Added .deepsource.toml to continuously analyze the repo for code quality issues

withshubh avatar Mar 25 '21 18:03 withshubh

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Mar 25 '21 18:03 google-cla[bot]

@googlebot I signed it!

withshubh avatar Mar 25 '21 18:03 withshubh

Hi Shubhendra,

Thank you very much for the PR! DeepSource sound like a very cool project. Unfortunately, we can not integrate '.toml' to the library as we need to maintain sync between the internal and external versions of the repo.

If that is fine with you, I am happy to review the PR assuming we do not push '.toml' file.

cyrilchim avatar Mar 26 '21 15:03 cyrilchim

Hi @cyrilchim :wave:

No worries! I removed the .deepsource.toml file.

I would really appreciate it if you could drop any suggestion on what we can do better to onboard you(or tf-quant-finance) on DeepSource. :)

withshubh avatar Mar 29 '21 19:03 withshubh