temporian icon indicating copy to clipboard operation
temporian copied to clipboard

New operators: bitwise int operations

Open ianspektor opened this issue 2 years ago • 3 comments

New EventSet.and(), EventSet.or(), EventSet.xor(), EventSet.invert(), EventSet.left_shift(), EventSet.right_shift() operators that implement bitwise operations on integer types, with their corresponding magics: &, |, ^, ~, <<, >>.

and() and or() and invert() are already implemented for bool and need to be extended to work with ints.

Implementation should be factored with base classes so that each operation only needs to define the numpy method it needs to call.

See https://github.com/google/temporian/blob/main/CONTRIBUTING.md#developing-a-new-operator for guidance.

Questions or requests for additional guidance from possible contributors more than welcome!

ianspektor avatar Jan 17 '24 20:01 ianspektor

I would like to take this up. Could you please assign this to me, @ianspektor?

saneens avatar Feb 29 '24 06:02 saneens

Hey @saneens! For sure. I see you've just joined our Discord too, feel free to create a thread in #contributing to discuss doubts or get additional help. Thanks!

ianspektor avatar Feb 29 '24 10:02 ianspektor

See how and, or and xor are implemented in temporian/core/operators/binary/logical.py and temporian/implementation/numpy/operators/binary/logical.py, these should be implemented with a similar structure.

ianspektor avatar Feb 29 '24 10:02 ianspektor