tamperchrome icon indicating copy to clipboard operation
tamperchrome copied to clipboard

DOM text reinterpreted as HTML Update inject.js

Open Shivam7-1 opened this issue 2 years ago • 3 comments

By using innerText, it will avoid the risk of HTML injection, as these properties automatically escape any HTML special characters in the provided text. This helps prevent cross-site scripting (XSS) vulnerabilities by treating the input as plain text rather than interpreted HTML. Always be cautious when dealing with user input or dynamic content to prevent security risks.

Shivam7-1 avatar Apr 16 '24 12:04 Shivam7-1

Hi @sirdarckcat Could You Please Review this PR Thanks

Shivam7-1 avatar Apr 16 '24 12:04 Shivam7-1

Hi @sirdarckcat Could You Please Review this PR Thanks

Shivam7-1 avatar Apr 19 '24 16:04 Shivam7-1

In this case innerHTML is being used as a getter, not a setter, so the existing code is perfectly safe. Further, it appears that changing this to text-only would break the following match, which seems to be looking for HTML attributes.

NeilFraser avatar Apr 19 '24 17:04 NeilFraser