syzkaller icon indicating copy to clipboard operation
syzkaller copied to clipboard

sys/targets: add environment variable support for ARM64 triple config…

Open happy2discover opened this issue 8 months ago • 6 comments

Instead of hard code ARM64 triple, a custom toolchain (e.g. aarch64-buildroot-linux-gnu) would be used sometimes


Before sending a pull request, please review Contribution Guidelines: https://github.com/google/syzkaller/blob/master/docs/contributing.md


happy2discover avatar Mar 28 '25 09:03 happy2discover

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Mar 28 '25 09:03 google-cla[bot]

@a-nogikh @tarasmadan could you please help to review? Thank you!

happy2discover avatar Mar 28 '25 09:03 happy2discover

Will symlink work for you?

tarasmadan avatar Mar 28 '25 14:03 tarasmadan

Will symlink work for you?

@tarasmadan yes, created symlinks to aarch64-buildroot-linux-gnu can work.

happy2discover avatar Apr 01 '25 06:04 happy2discover

Then the proposal is to use symlinks instead. My motivation: it will be much harder to find this flag that to symlink the binary. If we want to continue with syzkaller, it is better to enable this env variable for all the targets and extend documentation to make this new flag searchable. Do you agree?

tarasmadan avatar Apr 01 '25 08:04 tarasmadan

If we want to continue with syzkaller, it is better to enable this env variable for all the targets and extend documentation to make this new flag searchable.

+1

dvyukov avatar Apr 01 '25 12:04 dvyukov