syzkaller icon indicating copy to clipboard operation
syzkaller copied to clipboard

dashboard: periodically update/retest missed backports

Open dvyukov opened this issue 2 years ago • 2 comments

As pointed by Brad Spengler: We show a missed backport for v5.15: 4490e803 btrfs: don't start transaction when joining with TRANS_JOIN_NOSTART kernel BUG in close_ctree https://syzkaller.appspot.com/upstream/backports

This commit is in linux-5.15.y as:

commit f3260733894a3dff10ee271778af605ece0f331e
AuthorDate: Wed Jul 26 16:56:57 2023 +0100
CommitDate: Tue Sep 19 12:23:01 2023 +0200

    btrfs: don't start transaction when joining with TRANS_JOIN_NOSTART

The bug page says it was tested on 5.15 on Sep 16, the fix commit date is Sep 19. So it should not be showed on the missed backports page.

dvyukov avatar Jan 11 '24 06:01 dvyukov

The feature seems to be working, already > 10 deprecated backports since yesterday.

a-nogikh avatar Feb 09 '24 10:02 a-nogikh

There's a problem: we're reporting jobs that finished recently (that's an optimization to not query tons of DB entries every minute).

https://github.com/google/syzkaller/blob/77b23aa147a898d1e1912a5f01e6716bbdc3a59e/dashboard/app/jobs.go#L1203-L1206

But in this case jobs get Reported=False many months after the initial backport detection job was completed. As a result, nothing is reported.

Setting Finished to the current time would be a quick fix, but doesn't seem right.

a-nogikh avatar Feb 13 '24 11:02 a-nogikh