syzkaller icon indicating copy to clipboard operation
syzkaller copied to clipboard

sys/freebsd: update pf ioctl definitions

Open kprovost opened this issue 2 years ago • 4 comments

kprovost avatar Jun 27 '22 12:06 kprovost

Codecov Report

Merging #3220 (282e943) into master (496a853) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 282e943 differs from pull request most recent head 617eb39. Consider uploading reports for the commit 617eb39 to get more accurate results

codecov[bot] avatar Jun 27 '22 14:06 codecov[bot]

Looks like the last update didn't regenerate the syscall definitions?

Do you mean the constants in pf.txt.const? Those are the ioctl numbers and they didn't change. I'll fix the pfioc_nv definition, but I'm letting it run a few minutes here first, just in case.

kprovost avatar Jun 28 '22 19:06 kprovost

Looks like the last update didn't regenerate the syscall definitions?

Do you mean the constants in pf.txt.const? Those are the ioctl numbers and they didn't change. I'll fix the pfioc_nv definition, but I'm letting it run a few minutes here first, just in case.

The CI task is failing because gmake generate on your branch modifies pf.txt. On my system the result looks like this:

diff --git a/sys/freebsd/pf.txt b/sys/freebsd/pf.txt
index a48f2aafb..154ce83b1 100644
--- a/sys/freebsd/pf.txt
+++ b/sys/freebsd/pf.txt
@@ -154,7 +154,7 @@ pfioc_states_v2 {
 }
 
 pfioc_nv {
-       data            ptr[in, array[int8]]
-       len             int64
-       size            len[data, int64]
+       data    ptr[in, array[int8]]
+       len     int64
+       size    len[data, int64]
 }

I'm not sure why.

markjdb avatar Jun 29 '22 15:06 markjdb

The CI task is failing because gmake generate on your branch modifies pf.txt. On my system the result looks like this: I'm not sure why.

It looks like it's just unhappy with my whitespace choices. Let's try this.

kprovost avatar Jun 29 '22 18:06 kprovost