styleguide icon indicating copy to clipboard operation
styleguide copied to clipboard

ignore alt_tokens when checking fncall spacing

Open bkietz opened this issue 5 years ago • 6 comments

When readability/alt_tokens is disabled they can be parsed as a function name:

1 and (1 + 1)
     ^ spurious 'Extra space before ( in function call'

bkietz avatar Oct 03 '19 20:10 bkietz

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Oct 03 '19 20:10 googlebot

@googlebot I signed it!

bkietz avatar Oct 04 '19 01:10 bkietz

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Oct 04 '19 01:10 googlebot

Also consider contributing to the fork at https://github.com/cpplint/cpplint

tkruse avatar Dec 14 '19 12:12 tkruse

@tkruse I thought protocol was to get accepted here first?

bkietz avatar Dec 16 '19 15:12 bkietz

@bkietz: You are right in that this is upstream, and https://github.com/cpplint/cpplint is an unofficial fork, so the ideal process would be to merge here first and make the fork follow. However many good PRs here are never merged as evident in the PR history, whereas in the fork there is a little more flexibility to merge small changes.

Also I meant in a general sense, you could help maintaining the fork, if you like supporting cpplint.

tkruse avatar Dec 20 '19 13:12 tkruse