styleguide
styleguide copied to clipboard
ignore alt_tokens when checking fncall spacing
When readability/alt_tokens
is disabled they can be parsed as a function name:
1 and (1 + 1)
^ spurious 'Extra space before ( in function call'
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
Also consider contributing to the fork at https://github.com/cpplint/cpplint
@tkruse I thought protocol was to get accepted here first?
@bkietz: You are right in that this is upstream, and https://github.com/cpplint/cpplint is an unofficial fork, so the ideal process would be to merge here first and make the fork follow. However many good PRs here are never merged as evident in the PR history, whereas in the fork there is a little more flexibility to merge small changes.
Also I meant in a general sense, you could help maintaining the fork, if you like supporting cpplint.