startup-os Switch to using gRPC-Web for Reviewer

This includes both local_server and front-end code.

Sep 11 '18 15:09 oferb

Switch to using gRPC-Web for Reviewer webapp to localserver interaction.

Sep 11 '18 15:09 oferb

If you want this as a first issue, let us know and we'll explain it better. There's a working example to follow: https://github.com/oferb/startup-os-example/tree/master/app

Sep 14 '18 07:09 oferb

I would like to work on this. How can I proceed?

Oct 01 '18 01:10 wilder

Hey! Welcome :) So the first step is to get this example running: https://github.com/oferb/startup-os-example/tree/master/app and also ./build.sh and ./test.sh from this repo.

Then, take a look at the steps here: https://github.com/oferb/startup-os-example/blob/master/app/run_sample.sh

What you want to do, is have the proxy run against this gRPC server: https://github.com/google/startup-os/blob/master/tools/reviewer/local_server/local_server.sh That's the main challenge.

Let me know how it goes!

Oct 01 '18 08:10 oferb

How's it going?

Oct 04 '18 11:10 elinabtl

@elinabtl I haven't started working on it yet, I was planning to do it only during the weekend. Feel free to do it if you want to!

Oct 04 '18 11:10 wilder

It's ok, go ahead :)

On Thu, Oct 4, 2018 at 2:58 PM Wilder Pereira [email protected] wrote:

@elinabtl https://github.com/elinabtl I haven't working on it yet, I was planning to do it only during the weekend. Feel free to do it if you want to!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/google/startup-os/issues/289#issuecomment-426991515, or mute the thread https://github.com/notifications/unsubscribe-auth/AE5lByKZfzPIUrz4udHPb5nxkFWPl_odks5uhffNgaJpZM4Wjlqt .

Oct 04 '18 14:10 oferb