site-kit-wp icon indicating copy to clipboard operation
site-kit-wp copied to clipboard

Metric Widget Groups

Open benbowler opened this issue 1 year ago • 2 comments

Summary

Addresses issue:

  • #9376

Relevant technical choices

I branched from #9162 so that we can add the groups to the Top device driving purchases metric too.

PR Author Checklist

  • [ ] My code is tested and passes existing unit tests.
  • [ ] My code has an appropriate set of unit tests which all pass.
  • [x] My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • [x] My code follows the WordPress coding standards.
  • [ ] My code has proper inline documentation.
  • [x] I have added a QA Brief on the issue linked above.
  • [x] I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • [ ] Run the code.
  • [ ] Ensure the acceptance criteria are satisfied.
  • [ ] Reassess the implementation with the IB.
  • [ ] Ensure no unrelated changes are included.
  • [ ] Ensure CI checks pass.
  • [ ] Check Storybook where applicable.
  • [ ] Ensure there is a QA Brief.
  • [ ] Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • [ ] Ensure the PR has the correct target branch.
  • [ ] Double-check that the PR is okay to be merged.
  • [ ] Ensure the corresponding issue has a ZenHub release assigned.
  • [ ] Add a changelog message to the issue.

benbowler avatar Oct 15 '24 09:10 benbowler

@benbowler I am returning it to you back to execution since it has dependency that is not merged yet. I changed the PR to go against develop, it was sat agains another PR. After dependency has been merged please sync this PR and send it back to CR

zutigrm avatar Oct 15 '24 12:10 zutigrm

Sounds good, GH will update the base when merged so could be cleaner to keep the other branch as the base for now. I will keep an eye on it.

benbowler avatar Oct 15 '24 12:10 benbowler

Build files for 1584dadf965cbcdd7a74b3cdaf243f006bec856a have been deleted.

github-actions[bot] avatar Oct 29 '24 13:10 github-actions[bot]

Size Change: +1.75 kB (+0.1%)

Total Size: 1.84 MB

Filename Size Change
./dist/assets/js/googlesitekit-activation-********************.js 24 kB +39 B (+0.16%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 54.9 kB +30 B (+0.05%)
./dist/assets/js/googlesitekit-adminbar-********************.js 34.6 kB +85 B (+0.25%)
./dist/assets/js/googlesitekit-api-********************.js 10.1 kB +6 B (+0.06%)
./dist/assets/js/googlesitekit-components-gm2-********************.js 6.09 kB -1 B (-0.02%)
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB -1 B (-0.01%)
./dist/assets/js/googlesitekit-data-********************.js 2.37 kB -1 B (-0.04%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js 8.96 kB +12 B (+0.13%)
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB -1 B (-0.05%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 20.5 kB +22 B (+0.11%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js 10.1 kB +11 B (+0.11%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 27.2 kB +305 B (+1.14%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 81.5 kB +185 B (+0.23%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 158 kB +219 B (+0.14%)
./dist/assets/js/googlesitekit-modules-********************.js 22.2 kB -10 B (-0.04%)
./dist/assets/js/googlesitekit-modules-ads-********************.js 33.4 kB -6 B (-0.02%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 112 kB +205 B (+0.18%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 179 kB +231 B (+0.13%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.7 kB +129 B (+0.57%)
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 40.6 kB -45 B (-0.11%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 59.7 kB +199 B (+0.33%)
./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js 18.5 kB -38 B (-0.2%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 32.1 kB -64 B (-0.2%)
./dist/assets/js/googlesitekit-notifications-********************.js 22.7 kB -81 B (-0.36%)
./dist/assets/js/googlesitekit-settings-********************.js 120 kB -10 B (-0.01%)
./dist/assets/js/googlesitekit-splash-********************.js 68.8 kB -57 B (-0.08%)
./dist/assets/js/googlesitekit-user-input-********************.js 43.6 kB +53 B (+0.12%)
./dist/assets/js/googlesitekit-vendor-********************.js 322 kB +3 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js 91.2 kB +322 B (+0.35%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 62.6 kB +12 B (+0.02%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css 59.3 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.8 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.2 kB
./dist/assets/js/32-********************.js 2.76 kB
./dist/assets/js/33-********************.js 2.25 kB
./dist/assets/js/34-********************.js 3.64 kB
./dist/assets/js/35-********************.js 936 B
./dist/assets/js/36-********************.js 893 B
./dist/assets/js/37-********************.js 1.61 kB
./dist/assets/js/38-********************.js 1.57 kB
./dist/assets/js/39-********************.js 1.61 kB
./dist/assets/js/40-********************.js 1.59 kB
./dist/assets/js/41-********************.js 1.64 kB
./dist/assets/js/42-********************.js 3.11 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 901 B
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.6 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 646 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 624 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 630 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 712 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 675 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 634 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 657 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 633 B
./dist/assets/js/googlesitekit-i18n-********************.js 3.93 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 377 B
./dist/assets/js/runtime-********************.js 1.4 kB

compressed-size-action

github-actions[bot] avatar Oct 29 '24 13:10 github-actions[bot]