site-kit-wp Split the "Sell products or services" answer in the User Input app

Feature Description

As part of the updates to the User Input app, the existing "Sell products or services" question should be split into to separate questions, this requires some additional changes to logic to handle the behaviour with the legacy answer, as well as a banner for users who have previously selected the combined option. As part of this issue, only answer split should be added, banner will be implemented as separate issue

The proposed solution was discussed in a thread with @aaemnnosttv and @sigal-teller (message @benbowler for details), the summary of which is the following. Existing users who have selected the combined option should not be automatically migrated, these users should see a new banner in the Admin Settings screen when editing their metrics encouraging them to update the answer. The app metrics selection should continue working with the legacy combine answer selected.

This additional scope was first identified in #9374.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Existing purpose answer "Sell products or services" is split into two new answers:
- Sell products
- Provide services
New descriptions should be included under each answer, and answers should be added in order shown in Figma here and here
The legacy answer "Sell products or services" should still have an effect with the existing users that previously saved it, but it should be hidden from the answers list in the user input - both for new setup, and in the list when answer is edited in the key metrics section of the admin settings.
- For existing users, when editing the answer, Sell products which should be the first answer in the list, should be preselected by default
Check Splitting “Sell products or services” site purpose answer section of the design doc

Implementation Brief

[ ]

Test Coverage

QA Brief

Changelog entry

Oct 11 '24 08:10 benbowler

Taking this back to AC with me, pending the new tailored metrics that should be added for each new answer. Current thread for this

Oct 17 '24 12:10 zutigrm

AC looks good to me here ✅ I will move to IB and pick up myself.

Nov 04 '24 10:11 10upsimon

IB ✅

Nov 05 '24 13:11 zutigrm

@10upsimon I noticed the PR here created 5 metric tiles for the provide_services option. If ACR is not active, then the max number of tiles should be 4. Could we please bring this back down to 4 metrics?

https://github.com/google/site-kit-wp/blob/8913261d60a8593fe7bff01fac23086f7b5c6e71/assets/js/googlesitekit/datastore/user/key-metrics.js#L338-L344

Nov 21 '24 11:11 jimmymadon

QA Update ❌

Tested on dev environment.
Tested when 'connversionReporting' feature flag is not enabled.
Tested when 'connversionReporting' feature flag is enabled.

@10upsimon

Issue 1) 'connversionReporting' feature flag is not enabled. When I select purpose 'Provide services' then 5 metric tiles are showing. It should display 4 metric tiles.

Issue-2 ) When I select purpose 'Sell Products" and if "WooCommerce" plugin is active then 4 metric tiles are showing.

Most popular products by pageviews
Top traffic source
Most engaged traffic source
Top performing keywords

As per AC metric list "Most engaged traffic source" should be listed when purpose is "Provide Services". When 'connversionReporting' feature flag is enabled then metrics are showing correctly as per table mentioned under AC.

'conversionReporting' feature flag is enabled

"Sell Products"

Q -3) The Figma design for the "Answers Edit Screen" also includes a description, but this has not been implemented yet. I also tested this with ACR enabled. Do we have a separate ticket to implement this?

Nov 25 '24 01:11 mohitwp

QA Update ❌

@10upsimon Above listed issues are resolve now. Please find additional observations below -

Issue 4 : I missed this earlier due to metrics having similar names, but I’ve now noticed that when I select the purpose ‘Sell Products’, the following metrics are displayed. Out of these four, the “Top Traffic Source” metric is not part of the AC metrics list for ‘Sell Products’

Top earning pages
Most popular products by pageviews
Top traffic source
Top performing keywords

Issue 5: Now, 5 metrics are not showing when we select the purpose "Provide Services". However, in this case as well, the “Top Performing Keywords” metric is not part of the AC metrics list for "Provide Services".

Nov 27 '24 04:11 mohitwp

QA Update ✅

Tested on main environment.
Tested when 'connversionReporting' feature flag is not enabled.
Tested when 'connversionReporting' feature flag is enabled.
Verified issue number 4 reported above is resolved now.
Verified correct metrics tiles are showing as per list under AC when 'connversionReporting' feature flag is not enabled.

NOTE : @10upsimon I noticed one regression issue that if 'connversionReporting' feature flag is selected and if user selects purpose "Provide Services" then only 7 metrics are showing instead of 8. Upon comparing with the AC metrics list, I found that the “Top Pages by Returning Visitors” metric tile is missing. Additionally, this metric tile is also absent from the tailored metric suggestions. I created a separate ticket and assigned it to you since this issue is behind a feature flag. I believe creating a follow-up now wouldn’t be ideal, especially with the release scheduled for Monday.