site-kit-wp icon indicating copy to clipboard operation
site-kit-wp copied to clipboard

Enhancement/9162 Top Device Driving Purchases KMW

Open jimmymadon opened this issue 1 year ago • 4 comments

Summary

Addresses issue:

  • #9162

Relevant technical choices

PR Author Checklist

  • [x] My code is tested and passes existing unit tests.
  • [x] My code has an appropriate set of unit tests which all pass.
  • [x] My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • [x] My code follows the WordPress coding standards.
  • [x] My code has proper inline documentation.
  • [x] I have added a QA Brief on the issue linked above.
  • [x] I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • [x] Run the code.
  • [x] Ensure the acceptance criteria are satisfied.
  • [x] Reassess the implementation with the IB.
  • [x] Ensure no unrelated changes are included.
  • [x] Ensure CI checks pass.
  • [x] Check Storybook where applicable.
  • [x] Ensure there is a QA Brief.
  • [x] Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • [ ] Ensure the PR has the correct target branch.
  • [ ] Double-check that the PR is okay to be merged.
  • [ ] Ensure the corresponding issue has a ZenHub release assigned.
  • [ ] Add a changelog message to the issue.

jimmymadon avatar Oct 02 '24 07:10 jimmymadon

Build files for 1a40a42acaf98159ef0773af8a7a927e962b2848 have been deleted.

github-actions[bot] avatar Oct 02 '24 07:10 github-actions[bot]

Size Change: +260 B (+0.01%)

Total Size: 1.83 MB

Filename Size Change
./dist/assets/css/googlesitekit-admin-css-********************.min.css 58.9 kB +6 B (+0.01%)
./dist/assets/js/googlesitekit-activation-********************.js 23.9 kB +4 B (+0.02%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 54.7 kB -1 B (0%)
./dist/assets/js/googlesitekit-adminbar-********************.js 34.5 kB +8 B (+0.02%)
./dist/assets/js/googlesitekit-api-********************.js 10.1 kB +2 B (+0.02%)
./dist/assets/js/googlesitekit-components-gm2-********************.js 6.04 kB -2 B (-0.03%)
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB +1 B (+0.01%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js 8.95 kB +2 B (+0.02%)
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB -1 B (-0.05%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 20.5 kB +1 B (0%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js 10.1 kB +3 B (+0.03%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 26.8 kB +29 B (+0.11%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 81.3 kB +2 B (0%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 156 kB +32 B (+0.02%)
./dist/assets/js/googlesitekit-modules-ads-********************.js 33.4 kB +3 B (+0.01%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 111 kB +16 B (+0.01%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 178 kB +177 B (+0.1%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.6 kB +7 B (+0.03%)
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 40.6 kB -1 B (0%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 59.4 kB -39 B (-0.07%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 32.1 kB +2 B (+0.01%)
./dist/assets/js/googlesitekit-notifications-********************.js 22.7 kB -8 B (-0.04%)
./dist/assets/js/googlesitekit-settings-********************.js 118 kB -13 B (-0.01%)
./dist/assets/js/googlesitekit-splash-********************.js 68.8 kB +4 B (+0.01%)
./dist/assets/js/googlesitekit-user-input-********************.js 43.6 kB +5 B (+0.01%)
./dist/assets/js/googlesitekit-vendor-********************.js 321 kB +5 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js 90 kB +17 B (+0.02%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 62.5 kB -1 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.8 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.2 kB
./dist/assets/js/32-********************.js 2.76 kB
./dist/assets/js/33-********************.js 2.25 kB
./dist/assets/js/34-********************.js 3.64 kB
./dist/assets/js/35-********************.js 935 B
./dist/assets/js/36-********************.js 893 B
./dist/assets/js/37-********************.js 1.61 kB
./dist/assets/js/38-********************.js 1.57 kB
./dist/assets/js/39-********************.js 1.61 kB
./dist/assets/js/40-********************.js 1.59 kB
./dist/assets/js/41-********************.js 1.64 kB
./dist/assets/js/42-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 901 B
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.6 kB
./dist/assets/js/googlesitekit-data-********************.js 2.37 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 646 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 624 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 630 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 712 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 675 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 634 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 657 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 633 B
./dist/assets/js/googlesitekit-i18n-********************.js 3.93 kB
./dist/assets/js/googlesitekit-modules-********************.js 22.2 kB
./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js 18.1 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 377 B
./dist/assets/js/runtime-********************.js 1.4 kB

compressed-size-action

github-actions[bot] avatar Oct 02 '24 08:10 github-actions[bot]

One note here - before this PR is merged, this tile should be included in the list of tailored metrics to the designated purpose answers, follow the table in AC from this issue #9437

@jimmymadon @tofumatt

zutigrm avatar Oct 14 '24 07:10 zutigrm

One note here - before this PR is merged, this tile should be included in the list of tailored metrics to the designated purpose answers, follow the table in AC from this issue #9437

@zutigrm Thanks - from what I could see, this was already added as part of that issue. But after merging develop, there was one extra duplicated export that I have removed. So this should now be good to go @tofumatt but will wait for the CI tests to pass.

jimmymadon avatar Oct 16 '24 14:10 jimmymadon

Apologies, looks like I was ready to merge this then left the tab 😅

tofumatt avatar Oct 29 '24 12:10 tofumatt