site-kit-wp icon indicating copy to clipboard operation
site-kit-wp copied to clipboard

Add getServiceURL selector.

Open ankitrox opened this issue 1 year ago â€ĸ 2 comments

Summary

Addresses issue:

  • #8848

Relevant technical choices

PR Author Checklist

  • [ ] My code is tested and passes existing unit tests.
  • [ ] My code has an appropriate set of unit tests which all pass.
  • [ ] My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • [ ] My code follows the WordPress coding standards.
  • [ ] My code has proper inline documentation.
  • [x] I have added a QA Brief on the issue linked above.
  • [x] I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • [ ] Run the code.
  • [ ] Ensure the acceptance criteria are satisfied.
  • [ ] Reassess the implementation with the IB.
  • [ ] Ensure no unrelated changes are included.
  • [ ] Ensure CI checks pass.
  • [ ] Check Storybook where applicable.
  • [ ] Ensure there is a QA Brief.

Merge Reviewer Checklist

  • [ ] Ensure the PR has the correct target branch.
  • [ ] Double-check that the PR is okay to be merged.
  • [ ] Ensure the corresponding issue has a ZenHub release assigned.
  • [ ] Add a changelog message to the issue.

ankitrox avatar Jul 02 '24 14:07 ankitrox

Build files for 43e29c479549446938d7d934e8086738ca066819 have been deleted.

github-actions[bot] avatar Jul 04 '24 05:07 github-actions[bot]

Size Change: +3.87 kB (+0.25%)

Total Size: 1.58 MB

Filename Size Change
./dist/assets/css/googlesitekit-admin-css-********************.min.css 55.1 kB +37 B (+0.07%)
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.2 kB -3 B (-0.03%)
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 7.47 kB -2 B (-0.03%)
./dist/assets/js/googlesitekit-activation-********************.js 23.8 kB -191 B (-0.8%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 59.4 kB -88 B (-0.15%)
./dist/assets/js/googlesitekit-adminbar-********************.js 34.7 kB -143 B (-0.41%)
./dist/assets/js/googlesitekit-api-********************.js 10.1 kB -80 B (-0.79%)
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.87 kB -7 B (-0.12%)
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB +1 B (+0.01%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9.07 kB -67 B (-0.73%)
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB +3 B (+0.14%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 19.8 kB -106 B (-0.53%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js 10 kB -77 B (-0.76%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 25.1 kB +8 B (+0.03%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 75.7 kB +1.65 kB (+2.22%)
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 644 B -1 B (-0.16%)
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 623 B +8 B (+1.3%)
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 731 B +4 B (+0.55%)
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 674 B +1 B (+0.15%)
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 657 B +5 B (+0.77%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 125 kB +770 B (+0.62%)
./dist/assets/js/googlesitekit-modules-ads-********************.js 29.5 kB +50 B (+0.17%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 113 kB -95 B (-0.08%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 145 kB +791 B (+0.55%)
./dist/assets/js/googlesitekit-modules-********************.js 22.1 kB -26 B (-0.12%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.7 kB +113 B (+0.5%)
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 12.2 kB +963 B (+8.55%) 🔍
./dist/assets/js/googlesitekit-modules-search-console-********************.js 58.2 kB -156 B (-0.27%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 31.9 kB -45 B (-0.14%)
./dist/assets/js/googlesitekit-settings-********************.js 61.6 kB -161 B (-0.26%)
./dist/assets/js/googlesitekit-splash-********************.js 72.7 kB -738 B (-1%)
./dist/assets/js/googlesitekit-user-input-********************.js 48.1 kB -162 B (-0.34%)
./dist/assets/js/googlesitekit-vendor-********************.js 320 kB +12 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js 62.8 kB +838 B (+1.35%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 61.6 kB -66 B (-0.11%)
./dist/assets/js/googlesitekit-consent-mode-********************.js 836 B +836 B (new file) 🆕
â„šī¸ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 770 B
./dist/assets/js/30-********************.js 2.76 kB
./dist/assets/js/31-********************.js 2.25 kB
./dist/assets/js/32-********************.js 3.64 kB
./dist/assets/js/33-********************.js 935 B
./dist/assets/js/34-********************.js 892 B
./dist/assets/js/35-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 776 B
./dist/assets/js/googlesitekit-data-********************.js 2.36 kB
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 629 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 634 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 632 B
./dist/assets/js/googlesitekit-i18n-********************.js 3.92 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 377 B
./dist/assets/js/runtime-********************.js 1.3 kB

compressed-size-action

github-actions[bot] avatar Jul 04 '24 05:07 github-actions[bot]

Hi @ankitrox 👋 All my code review comments were not addressed, so I'm sending this back to you for another look. Please let me know if you have any questions. Thanks.

Hi @nfmohit 👋đŸŧ Sorry for that! I've addressed couple of comments that went unaddressed. The other one was addressed, but not showing that it has been changed, so I've added comment in that one.

Over to you for review.

Thanks

ankitrox avatar Jul 10 '24 06:07 ankitrox