site-kit-wp icon indicating copy to clipboard operation
site-kit-wp copied to clipboard

RRM: getPublications selector

Open ankitrox opened this issue 1 year ago • 2 comments

Summary

Addresses issue:

  • #8794

Relevant technical choices

PR Author Checklist

  • [ ] My code is tested and passes existing unit tests.
  • [ ] My code has an appropriate set of unit tests which all pass.
  • [ ] My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • [ ] My code follows the WordPress coding standards.
  • [ ] My code has proper inline documentation.
  • [ ] I have added a QA Brief on the issue linked above.
  • [x] I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • [ ] Run the code.
  • [ ] Ensure the acceptance criteria are satisfied.
  • [ ] Reassess the implementation with the IB.
  • [ ] Ensure no unrelated changes are included.
  • [ ] Ensure CI checks pass.
  • [ ] Check Storybook where applicable.
  • [ ] Ensure there is a QA Brief.

Merge Reviewer Checklist

  • [ ] Ensure the PR has the correct target branch.
  • [ ] Double-check that the PR is okay to be merged.
  • [ ] Ensure the corresponding issue has a ZenHub release assigned.
  • [ ] Add a changelog message to the issue.

ankitrox avatar Jul 02 '24 06:07 ankitrox

Build files for d3b0e3507c8cc01e6f31ea42c8750c65421ecbb3 have been deleted.

github-actions[bot] avatar Jul 04 '24 05:07 github-actions[bot]

Size Change: +197 B (+0.01%)

Total Size: 1.58 MB

Filename Size Change
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 12.4 kB +197 B (+1.61%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css 55.3 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.2 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 770 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 7.47 kB
./dist/assets/js/30-********************.js 2.76 kB
./dist/assets/js/31-********************.js 2.25 kB
./dist/assets/js/32-********************.js 3.64 kB
./dist/assets/js/33-********************.js 935 B
./dist/assets/js/34-********************.js 892 B
./dist/assets/js/35-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 776 B
./dist/assets/js/googlesitekit-activation-********************.js 23.8 kB
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 59.4 kB
./dist/assets/js/googlesitekit-adminbar-********************.js 34.7 kB
./dist/assets/js/googlesitekit-api-********************.js 10.1 kB
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.88 kB
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB
./dist/assets/js/googlesitekit-consent-mode-********************.js 836 B
./dist/assets/js/googlesitekit-data-********************.js 2.36 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9.07 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB
./dist/assets/js/googlesitekit-datastore-site-********************.js 19.8 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 10 kB
./dist/assets/js/googlesitekit-datastore-user-********************.js 25.1 kB
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 75.2 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 644 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 623 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 629 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 731 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 674 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 634 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 657 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 632 B
./dist/assets/js/googlesitekit-i18n-********************.js 3.92 kB
./dist/assets/js/googlesitekit-main-dashboard-********************.js 126 kB
./dist/assets/js/googlesitekit-modules-ads-********************.js 29.5 kB
./dist/assets/js/googlesitekit-modules-adsense-********************.js 113 kB
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 145 kB
./dist/assets/js/googlesitekit-modules-********************.js 22.1 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.7 kB
./dist/assets/js/googlesitekit-modules-search-console-********************.js 58.2 kB
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 31.9 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 377 B
./dist/assets/js/googlesitekit-settings-********************.js 61.7 kB
./dist/assets/js/googlesitekit-splash-********************.js 72.9 kB
./dist/assets/js/googlesitekit-user-input-********************.js 48.1 kB
./dist/assets/js/googlesitekit-vendor-********************.js 320 kB
./dist/assets/js/googlesitekit-widgets-********************.js 62.9 kB
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 61.5 kB
./dist/assets/js/runtime-********************.js 1.3 kB

compressed-size-action

github-actions[bot] avatar Jul 04 '24 05:07 github-actions[bot]

Excellent work on this, thank you @ankitrox ! I've left a few comments, after addressing which, we should be able to get this merged.

Also, could you please update the QAB and mention the following:

  1. Activating the rrmModule feature flag and the Reader Revenue Manager module, otherwise, the request won't work.
  2. It is not guaranteed that the response will be empty. The Google account used to test this may actually have publications.

Please take a look and feel free to let me know if you have any questions. Thank you!

Thanks @nfmohit .

I've updated the QAB and addressed the feedback.

Over to you for re-review.

ankitrox avatar Jul 10 '24 07:07 ankitrox