Enhancement/8211 decouple module effects
Summary
Addresses issue:
- #8211
Relevant technical choices
PR Author Checklist
- [x] My code is tested and passes existing unit tests.
- [ ] My code has an appropriate set of unit tests which all pass.
- [ ] My code is backward-compatible with WordPress 5.2 and PHP 7.4.
- [ ] My code follows the WordPress coding standards.
- [ ] My code has proper inline documentation.
- [ ] I have added a QA Brief on the issue linked above.
- [x] I have signed the Contributor License Agreement (see https://cla.developers.google.com/).
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
- [ ] Run the code.
- [ ] Ensure the acceptance criteria are satisfied.
- [ ] Reassess the implementation with the IB.
- [ ] Ensure no unrelated changes are included.
- [ ] Ensure CI checks pass.
- [ ] Check Storybook where applicable.
- [ ] Ensure there is a QA Brief.
Merge Reviewer Checklist
- [ ] Ensure the PR has the correct target branch.
- [ ] Double-check that the PR is okay to be merged.
- [ ] Ensure the corresponding issue has a ZenHub release assigned.
- [ ] Add a changelog message to the issue.
Build files for b4958220b6515eb60905df4501eb07f0733b8300 have been deleted.
Size Change: +384 B (+0.02%)
Total Size: 1.57 MB
| Filename | Size | Change |
|---|---|---|
./dist/assets/js/googlesitekit-activation-********************.js |
24 kB | -3 B (-0.01%) |
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js |
59.5 kB | +7 B (+0.01%) |
./dist/assets/js/googlesitekit-adminbar-********************.js |
34.8 kB | -8 B (-0.02%) |
./dist/assets/js/googlesitekit-api-********************.js |
10.2 kB | -4 B (-0.04%) |
./dist/assets/js/googlesitekit-components-gm2-********************.js |
5.88 kB | +4 B (+0.07%) |
./dist/assets/js/googlesitekit-components-gm3-********************.js |
10.1 kB | -1 B (-0.01%) |
./dist/assets/js/googlesitekit-data-********************.js |
2.37 kB | +5 B (+0.21%) |
./dist/assets/js/googlesitekit-datastore-forms-********************.js |
9.13 kB | -1 B (-0.01%) |
./dist/assets/js/googlesitekit-datastore-location-********************.js |
2.08 kB | +1 B (+0.05%) |
./dist/assets/js/googlesitekit-datastore-site-********************.js |
19.9 kB | +9 B (+0.05%) |
./dist/assets/js/googlesitekit-datastore-ui-********************.js |
10.1 kB | -1 B (-0.01%) |
./dist/assets/js/googlesitekit-datastore-user-********************.js |
25.1 kB | +7 B (+0.03%) |
./dist/assets/js/googlesitekit-entity-dashboard-********************.js |
74.2 kB | +152 B (+0.21%) |
./dist/assets/js/googlesitekit-main-dashboard-********************.js |
124 kB | -297 B (-0.24%) |
./dist/assets/js/googlesitekit-modules-ads-********************.js |
29.5 kB | +20 B (+0.07%) |
./dist/assets/js/googlesitekit-modules-adsense-********************.js |
113 kB | -7 B (-0.01%) |
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js |
145 kB | +655 B (+0.45%) |
./dist/assets/js/googlesitekit-modules-********************.js |
22.2 kB | +75 B (+0.34%) |
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js |
22.6 kB | +12 B (+0.05%) |
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js |
11.3 kB | -3 B (-0.03%) |
./dist/assets/js/googlesitekit-modules-search-console-********************.js |
58.4 kB | -9 B (-0.02%) |
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js |
31.9 kB | +1 B (0%) |
./dist/assets/js/googlesitekit-settings-********************.js |
61.7 kB | -19 B (-0.03%) |
./dist/assets/js/googlesitekit-splash-********************.js |
73.5 kB | +32 B (+0.04%) |
./dist/assets/js/googlesitekit-user-input-********************.js |
48.3 kB | +10 B (+0.02%) |
./dist/assets/js/googlesitekit-vendor-********************.js |
320 kB | +66 B (+0.02%) |
./dist/assets/js/googlesitekit-widgets-********************.js |
62.1 kB | -299 B (-0.48%) |
./dist/assets/js/googlesitekit-wp-dashboard-********************.js |
61.6 kB | -20 B (-0.03%) |
ℹ️ View Unchanged
| Filename | Size |
|---|---|
./dist/assets/css/googlesitekit-admin-css-********************.min.css |
55.1 kB |
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css |
11.2 kB |
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css |
770 B |
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css |
7.47 kB |
./dist/assets/js/30-********************.js |
2.76 kB |
./dist/assets/js/31-********************.js |
2.25 kB |
./dist/assets/js/32-********************.js |
3.64 kB |
./dist/assets/js/33-********************.js |
935 B |
./dist/assets/js/34-********************.js |
892 B |
./dist/assets/js/35-********************.js |
3.11 kB |
./dist/assets/js/analytics-advanced-tracking-********************.js |
776 B |
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js |
645 B |
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js |
615 B |
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js |
629 B |
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js |
727 B |
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js |
673 B |
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js |
634 B |
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js |
652 B |
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js |
632 B |
./dist/assets/js/googlesitekit-i18n-********************.js |
3.92 kB |
./dist/assets/js/googlesitekit-polyfills-********************.js |
377 B |
./dist/assets/js/runtime-********************.js |
1.3 kB |
@aaemnnosttv Thanks, it seems there is still a weird error happening, I will try to debug this tomorrow
@aaemnnosttv It seems action from useMount is causing E2E failure when moved to child components, moving it into the main dashboard still causes tests to fail. It seems even a small delay in timing is affecting the behaviour.
I returned the action back to the entry point component. And opened a follow up issue to investigate further about moving it into the effects component #8951