site-kit-wp icon indicating copy to clipboard operation
site-kit-wp copied to clipboard

Use the correct title font for the Consent Mode Setup CTA Banner

Open techanvil opened this issue 1 year ago • 1 comments

Feature Description

The Consent Mode Setup CTA Banner has been implemented with a title font of Google Sans Text. However, as per the Figma design, it should be Google Sans Display.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The title font for the Consent Mode Setup CTA Banner should be Google Sans Display.

Implementation Brief

  • [ ] Change the font-family value for the main .googlesitekit-setup-cta-banner__title class definition to $f-secondary. https://github.com/google/site-kit-wp/blob/721401ea2fac18fad433bf2e066aaa486aa83e79/assets/sass/components/dashboard/_googlesitekit-setup-cta-banner.scss#L29-L30

  • [ ] The override for the Ads banner can be removed: https://github.com/google/site-kit-wp/blob/721401ea2fac18fad433bf2e066aaa486aa83e79/assets/sass/components/ads/_googlesitekit-ads-setup-banner.scss#L30-L31

Test Coverage

  • Update VRT reference images as needed.

QA Brief

  • Enable a VPN so your request is coming from an EU country (for instance, Germany)
  • Set up Site Kit on a new site
  • The Consent Mode title ("Enable Consent Mode to preserve…") should be using Google Sans Display

Changelog entry

  • N/A

techanvil avatar Jun 18 '24 14:06 techanvil

IB ✔️

eugene-manuilov avatar Jun 18 '24 17:06 eugene-manuilov

QA Update ✅

  • Tested on dev environment.
  • Verified title font for the Consent Mode Setup CTA Banner is now Google Sans Display.

image

mohitwp avatar Jul 08 '24 12:07 mohitwp