site-kit-wp icon indicating copy to clipboard operation
site-kit-wp copied to clipboard

Add GA tracking for RRM

Open nfmohit opened this issue 1 year ago • 1 comments

Feature Description

GA event tracking should be added to different parts of the RRM module, such as the user-facing banner notification (#8846), publication-approved overlay notification (#8843), publication onboarding state notice (#8838), and module success banner (#8840).


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

  • [ ]

Test Coverage

QA Brief

Changelog entry

nfmohit avatar Jun 08 '24 13:06 nfmohit

This is blocked by this internal task to define GA tracking parameters for Reader Revenue Management.

nfmohit avatar Jun 26 '24 09:06 nfmohit

Thank you for the IB, @ankitrox . Please take a look at my comments below:

In assets/js/modules/reader-revenue-manager/components/dashboard/PublicationApprovedOverlayNotification.js component added in Implement <PublicationApprovedOverlayNotification> component #8843, do the following.

  • [ ] Add the useEffect hook in the component to track the view_notification event with category name {viewContext}_rrm-publication-approved-notification.

To track the view notification for the overlay notification, we should use the onShow prop instead.

Also, do you think we should increase the estimate by a notch as these are a lot of components and involves quite extensive test coverage, just to be on the safe side?

nfmohit avatar Aug 07 '24 23:08 nfmohit

Thank you @nfmohit .

I've updated the point to pass onShow prop to OverlayNotification component.

Also, I've bumped the estimate to 19 as I agree that there are lot of places for update and this may cause some unforeseen issues in tests or any other places.

ankitrox avatar Aug 08 '24 07:08 ankitrox

Thank you @ankitrox!

IB ✅

nfmohit avatar Aug 08 '24 09:08 nfmohit

QA Update: ✅

Verified

  • I went through all of the GA events in the AC and ensured that they are fired when the appropriate scenario is met. I went through the dashboard, setting up the module, viewing and editing the module settings and the overlay notification
Screenshots

image image image image image image image image image image image image image image image image image image image image image

wpdarren avatar Aug 20 '24 06:08 wpdarren