Add GA tracking for RRM
Feature Description
GA event tracking should be added to different parts of the RRM module, such as the user-facing banner notification (#8846), publication-approved overlay notification (#8843), publication onboarding state notice (#8838), and module success banner (#8840).
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
- [ ]
Test Coverage
QA Brief
Changelog entry
This is blocked by this internal task to define GA tracking parameters for Reader Revenue Management.
Thank you for the IB, @ankitrox . Please take a look at my comments below:
In
assets/js/modules/reader-revenue-manager/components/dashboard/PublicationApprovedOverlayNotification.jscomponent added in Implement<PublicationApprovedOverlayNotification>component #8843, do the following.
- [ ] Add the
useEffecthook in the component to track theview_notificationevent with category name{viewContext}_rrm-publication-approved-notification.
To track the view notification for the overlay notification, we should use the onShow prop instead.
Also, do you think we should increase the estimate by a notch as these are a lot of components and involves quite extensive test coverage, just to be on the safe side?
Thank you @nfmohit .
I've updated the point to pass onShow prop to OverlayNotification component.
Also, I've bumped the estimate to 19 as I agree that there are lot of places for update and this may cause some unforeseen issues in tests or any other places.
Thank you @ankitrox!
IB ✅
QA Update: ✅
Verified
- I went through all of the GA events in the AC and ensured that they are fired when the appropriate scenario is met. I went through the dashboard, setting up the module, viewing and editing the module settings and the overlay notification
Screenshots