site-kit-wp icon indicating copy to clipboard operation
site-kit-wp copied to clipboard

Enhancement/8661 pax success banner

Open zutigrm opened this issue 1 year ago • 2 comments

Summary

Addresses issue:

  • #8661

Relevant technical choices

  • Note, the current VRT is the existing Ads setup success one, so it is expected show me button is not present. The PAX success notification only has stories, but it is not added to the VRT, as that part of the IB test section is crossed.

PR Author Checklist

  • [x] My code is tested and passes existing unit tests.
  • [ ] My code has an appropriate set of unit tests which all pass.
  • [ ] My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • [ ] My code follows the WordPress coding standards.
  • [ ] My code has proper inline documentation.
  • [x] I have added a QA Brief on the issue linked above.
  • [x] I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • [ ] Run the code.
  • [ ] Ensure the acceptance criteria are satisfied.
  • [ ] Reassess the implementation with the IB.
  • [ ] Ensure no unrelated changes are included.
  • [ ] Ensure CI checks pass.
  • [ ] Check Storybook where applicable.
  • [ ] Ensure there is a QA Brief.

Merge Reviewer Checklist

  • [ ] Ensure the PR has the correct target branch.
  • [ ] Double-check that the PR is okay to be merged.
  • [ ] Ensure the corresponding issue has a ZenHub release assigned.
  • [ ] Add a changelog message to the issue.

zutigrm avatar May 20 '24 10:05 zutigrm

Build files for f2f696ff36d9d70a2e644488a24336d0bc9d8f71 have been deleted.

github-actions[bot] avatar May 20 '24 10:05 github-actions[bot]

Size Change: +3.37 kB (+0.23%)

Total Size: 1.47 MB

Filename Size Change
./dist/assets/css/googlesitekit-admin-css-********************.min.css 54.2 kB +101 B (+0.19%)
./dist/assets/js/34-********************.js 3.12 kB +1 B (+0.03%)
./dist/assets/js/googlesitekit-activation-********************.js 23.9 kB -5 B (-0.02%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 58.7 kB +492 B (+0.84%)
./dist/assets/js/googlesitekit-adminbar-********************.js 34.6 kB +23 B (+0.07%)
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.88 kB +5 B (+0.09%)
./dist/assets/js/googlesitekit-components-gm3-********************.js 10 kB -1 B (-0.01%)
./dist/assets/js/googlesitekit-data-********************.js 2.18 kB +1 B (+0.05%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9.14 kB +2 B (+0.02%)
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.09 kB +1 B (+0.05%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 19.9 kB -5 B (-0.03%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js 10.1 kB +3 B (+0.03%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 25.1 kB -351 B (-1.38%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 72.8 kB +467 B (+0.65%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 114 kB +489 B (+0.43%)
./dist/assets/js/googlesitekit-modules-ads-********************.js 27.1 kB +76 B (+0.28%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 112 kB +534 B (+0.48%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 111 kB +32 B (+0.03%)
./dist/assets/js/googlesitekit-modules-********************.js 21.6 kB +4 B (+0.02%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.4 kB +8 B (+0.04%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 58 kB +3 B (+0.01%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 30.6 kB +14 B (+0.05%)
./dist/assets/js/googlesitekit-settings-********************.js 61 kB +529 B (+0.88%)
./dist/assets/js/googlesitekit-splash-********************.js 72.9 kB +473 B (+0.65%)
./dist/assets/js/googlesitekit-user-input-********************.js 48.1 kB +487 B (+1.02%)
./dist/assets/js/googlesitekit-vendor-********************.js 317 kB +2 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js 33.7 kB -6 B (-0.02%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 60 kB -15 B (-0.02%)
./dist/assets/js/runtime-********************.js 1.3 kB +4 B (+0.31%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.2 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 731 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 7.48 kB
./dist/assets/js/29-********************.js 2.8 kB
./dist/assets/js/30-********************.js 2.28 kB
./dist/assets/js/31-********************.js 3.72 kB
./dist/assets/js/32-********************.js 929 B
./dist/assets/js/33-********************.js 888 B
./dist/assets/js/analytics-advanced-tracking-********************.js 778 B
./dist/assets/js/contact-form-7-********************.js 646 B
./dist/assets/js/googlesitekit-api-********************.js 10.1 kB
./dist/assets/js/googlesitekit-i18n-********************.js 3.92 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 380 B
./dist/assets/js/mailchimp-********************.js 632 B
./dist/assets/js/optin-monster-********************.js 669 B
./dist/assets/js/popup-maker-********************.js 634 B
./dist/assets/js/woocommerce-********************.js 655 B
./dist/assets/js/wpforms-********************.js 634 B

compressed-size-action

github-actions[bot] avatar May 20 '24 10:05 github-actions[bot]

Thanks @tofumatt PR updated

zutigrm avatar May 22 '24 08:05 zutigrm

@tofumatt Conflicts fixed. E2E nightly seems to be failing for some unrelated test regarding admin-bar

zutigrm avatar May 24 '24 10:05 zutigrm