site-kit-wp icon indicating copy to clipboard operation
site-kit-wp copied to clipboard

Create Audience Tile Error component.

Open benbowler opened this issue 1 year ago • 3 comments

Summary

Addresses issue:

  • #8228

Relevant technical choices

See comment below.

PR Author Checklist

  • [x] My code is tested and passes existing unit tests.
  • [ ] My code has an appropriate set of unit tests which all pass.
  • [x] My code is backward-compatible with WordPress 5.2 and PHP 5.6.
  • [x] My code follows the WordPress coding standards.
  • [ ] My code has proper inline documentation.
  • [x] I have added a QA Brief on the issue linked above.
  • [x] I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • [ ] Run the code.
  • [ ] Ensure the acceptance criteria are satisfied.
  • [ ] Reassess the implementation with the IB.
  • [ ] Ensure no unrelated changes are included.
  • [ ] Ensure CI checks pass.
  • [ ] Check Storybook where applicable.
  • [ ] Ensure there is a QA Brief.

Merge Reviewer Checklist

  • [ ] Ensure the PR has the correct target branch.
  • [ ] Double-check that the PR is okay to be merged.
  • [ ] Ensure the corresponding issue has a ZenHub release assigned.
  • [ ] Add a changelog message to the issue.

benbowler avatar Mar 25 '24 15:03 benbowler

Build files for 6acae9f04f9d9c6293372d640b292c92038b1ab4 have been deleted.

github-actions[bot] avatar Mar 25 '24 15:03 github-actions[bot]

Size Change: +322 B (0%)

Total Size: 1.42 MB

Filename Size Change
./dist/assets/css/googlesitekit-admin-css-********************.min.css 53.1 kB +160 B (0%)
./dist/assets/js/34-********************.js 3.12 kB -1 B (0%)
./dist/assets/js/googlesitekit-activation-********************.js 23.8 kB +7 B (0%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 57.3 kB -48 B (0%)
./dist/assets/js/googlesitekit-adminbar-********************.js 34.1 kB +4 B (0%)
./dist/assets/js/googlesitekit-api-********************.js 10 kB +5 B (0%)
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.88 kB +15 B (0%)
./dist/assets/js/googlesitekit-components-gm3-********************.js 10 kB -1 B (0%)
./dist/assets/js/googlesitekit-data-********************.js 2.17 kB -2 B (0%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9.12 kB +5 B (0%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 19 kB +657 B (+4%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js 10.1 kB +8 B (0%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 24.4 kB -20 B (0%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 66.7 kB -69 B (0%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 91.2 kB -87 B (0%)
./dist/assets/js/googlesitekit-modules-********************.js 21.7 kB +4 B (0%)
./dist/assets/js/googlesitekit-modules-ads-********************.js 16.8 kB +137 B (+1%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 111 kB -90 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 111 kB -63 B (0%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.6 kB +61 B (0%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 57.9 kB -58 B (0%)
./dist/assets/js/googlesitekit-settings-********************.js 58.7 kB -254 B (0%)
./dist/assets/js/googlesitekit-splash-********************.js 71.9 kB -66 B (0%)
./dist/assets/js/googlesitekit-user-input-********************.js 46.8 kB -22 B (0%)
./dist/assets/js/googlesitekit-vendor-********************.js 316 kB +3 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js 33.3 kB +23 B (0%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 60 kB +13 B (0%)
./dist/assets/js/runtime-********************.js 1.3 kB +1 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.2 kB
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 7.47 kB
./dist/assets/js/29-********************.js 2.8 kB
./dist/assets/js/30-********************.js 2.28 kB
./dist/assets/js/31-********************.js 3.72 kB
./dist/assets/js/32-********************.js 930 B
./dist/assets/js/33-********************.js 888 B
./dist/assets/js/analytics-advanced-tracking-********************.js 778 B
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.09 kB
./dist/assets/js/googlesitekit-i18n-********************.js 3.92 kB
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 30 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 379 B

compressed-size-action

github-actions[bot] avatar Mar 25 '24 15:03 github-actions[bot]

Hey @hussain-t + @techanvil, based on your comments I refactored this AudienceTileError component to use the ReportErrorActions component, to do that I had to add some additional props and code to it. It did greatly reduce the duplication of code into the AudienceTileError component.

A number of other elements from the original review were removed as part of this work and I addressed all the rest.

Back to you @hussain-t for another look.

benbowler avatar Mar 27 '24 14:03 benbowler