Reword "Existing Tag" messages and other language changes for SAM

[jimmymadon]

Feature Description

This issue covers the following Asana E2E testing issues which deal with "language" changes: https://app.asana.com/0/1206822627583085/1206848566636390/f https://app.asana.com/0/1206822627583085/1206830601119693/f

A. Existing Tag Message Within the GA4 "setup" and "edit settings" forms, a message is displayed which informs the user if an existing GA4 tag is found on their site. All of these messages were originally created for UA settings where a duplicate tag would duplicate events sent to UA. We still decided to port the existing tag detection functionality along with the messages over even for GA4 (Slack thread). If the existing tag matches the tag for the currently selected property (Case 1 and 2 in the screenshots below), the message sounds like a warning that suggests that something bad could happen in terms of duplication if two tags are placed on the site. This is no longer true for GA4 and so we should update the message to something more lenient.

Case 1: Setup with existing duplicate tag

Case 2: Settings with existing duplicate tag

Case 3: Setup with existing different tag

Case 4: Settings with existing different tag

B. Other GA4 references Furthermore, for simplicity, we should consider removing older lingering references to GA4.

GA4 reference in Settings

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• Within the GA4 and Tag Manager module's "Setup" and "Settings" forms, if an existing tag is detected and it matches the tag found within the currently selected property / container, then the original message below should be modified to the new message as follows:

  • Original Message: A tag G-ABCDE12FGH for the selected property already exists on the site Make sure you remove it if you decide to place the same GA4 tag via Site Kit, otherwise they will be duplicated
  • New Message: A tag G-ABCDE12FGH for the selected property already exists on the site Consider removing the existing tag to avoid loading both tags on your site.

• Within the GA4 "Setup" and "Settings" forms, remove all references to "GA4".

  • Original Messages:
    1. Site Kit will add the GA4 code automatically
    2. Site Kit will not add the GA4 code to your site
  • New Messages (use the same language as in Tag Manager currently):
    1. Site Kit will add the code automatically
    2. Site Kit will not add the code to your site

Implementation Brief

• [ ] Within the SettingsUseSnippetSwitch and SetupUseSnippetSwitch components in both, analytics-4 and tagmanager, update the description messages as per the AC.

Test Coverage

• No new tests required.

QA Brief

• Use the tester plugin to add a valid Measurement ID within the Analytics Existing tag setting. Now set up Analytics and edit the Analytics settings as well as set up GTM and edit GTM settings to see the messages within the AC.
• Note: I have had issues replicating the "Settings with existing different tag" scenarios - please enquire on Slack or ask Nahid on how he was able to replicate these.

Changelog entry

• Update wording for sites with existing Analytics tags.

[marrrmarrr]

this all looks great, thanks @jimmymadon !

[jimmymadon]

@aaemnnosttv kind of approved the ACs and IB here so have started execution on this being a very minor issue.

[wpdarren]

QA Update: ⚠️

@tofumatt I have tried this with two new sites, but I cannot see the new text. It should say:

A tag G-SHXWZ83GQY for the selected property already exists on the site. Consider removing the existing tag to avoid loading both tags on your site.

I still see:

A tag G-SHXWZ83GQY for the selected property already exists on the site. Make sure you remove it if you decide to place the same GA4 tag via Site Kit, otherwise they will be duplicated

I refreshed the development branch a few times. Any idea why I do not see the text change?

[wpdarren]

QA Update: ❌

As per conversation with @tofumatt on Slack, sending this back to execution for a fix.

[wpdarren]

QA Update: ⚠️

@tofumatt I feel a scenario has been missed here in the ACs. I see the correct copy when the duplicate Measurement ID is the same when setting up Analytics. The issue is when the duplicate Measurement ID differs from the property/web data stream you've selected when setting up Analytics. As you can see from the screenshot below, the GA4 is still referenced.

It was my understanding that we would remove the GA4 reference.

Interested in your thoughts.

[tofumatt]

@wpdarren Hmm, fair enough. Might as well do that as part of this issue, I'll take this over and look for any remaining "GA4" text.

[tofumatt]

Looks like that's the only instance aside from https://google.github.io/site-kit-wp/storybook/develop/?path=/story/consent-mode-settingscardconsentmode--with-ads-connected, which makes sense to keep as GA4 🙂

[nfmohit]

QA Update: ⚠️

@tofumatt I feel a scenario has been missed here in the ACs. I see the correct copy when the duplicate Measurement ID is the same when setting up Analytics. The issue is when the duplicate Measurement ID differs from the property/web data stream you've selected when setting up Analytics. As you can see from the screenshot below, the GA4 is still referenced.

It was my understanding that we would remove the GA4 reference.

Interested in your thoughts.

This has now been addressed and merged. Back with you for another pass, thanks @wpdarren!

[wpdarren]

QA Update: ✅

Verified:

• I went through all of the scenarios for the setup and settings screens to ensure that the GA4 references were removed and, where appropriate, the copy in the AC matches. This was tested when the measurement ID for an existing tag was the same as that used to set up Analytics on Site Kit and a different one. I also made sure that the GA4 reference when no existing tag was removed from the copy. All good 👍

Screenshots