site-kit-wp icon indicating copy to clipboard operation
site-kit-wp copied to clipboard
verified publisher icon google

Change the `Ads Conversion ID` Field to `Conversion Tracking ID`

Open 10upsimon opened this issue 1 year ago • 3 comments

Feature Description

As part of a recent set of Ads Module updates issues, the need to update the field named Ads Conversion ID was raised. The field, contained within the SetupComponent, SettingsEdit and SettingsView components, should now be called "Conversion Tracking ID".

Figma Reference: https://www.figma.com/file/THG1FJw5SaUxmiq38Mkf1x/Ads?type=design&node-id=653-3876&mode=design&t=jlu0HcZCByxfpa3E-0

image.png

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The current field labelled with value of "Ads Conversion ID" (found in SetupComponent, SettingsView and SettingsEdit components within the Ads module) should have the label updated to read as follows: "Conversion Tracking ID"

Implementation Brief

  • Rename the "Ads Conversion ID" labels to "Conversion Tracking ID" in the following components:
    • /assets/js/modules/analytics/components/common/AdsConversionIDTextField.js
    • assets/js/modules/analytics/components/settings/OptionalSettingsView.js
    • assets/js/modules/analytics-4/components/common/AdsConversionIDTextField.js
    • assets/js/modules/analytics-4/components/settings/OptionalSettingsView.js
  • In assets/js/modules/analytics-4/components/common/AdsConversionIDTextField.js also rename the description.

Test Coverage

  • Update VRT reference images

QA Brief

  • Enable the adsModule feature flag.
  • Set up Ads and note the label now reads "Conversion Tracking ID", not "Ads Conversion ID".

Changelog entry

10upsimon avatar Mar 13 '24 14:03 10upsimon

AC ✔️

eugene-manuilov avatar Mar 13 '24 14:03 eugene-manuilov

Not included in the AC, but for the AdsConversionIDTextField component, we should also rename the field description, so the field label and description use consistent wording.

derweili avatar Mar 15 '24 09:03 derweili

IB ✔️

eugene-manuilov avatar Mar 18 '24 17:03 eugene-manuilov

As pointed out by @nfmohit (see: https://github.com/google/site-kit-wp/pull/8436#pullrequestreview-1971155488), this issue isn't actually needed as the changes for this field in Analytics aren't relevant now that this setting has been moved to the Ads module.

I have created a follow-up issue to make sure settings variables and selectors are updated to reference this new value (#8473), but this issue can be closed as these changes aren't needed for the Analytics module, where this will be replaced.

tofumatt avatar Apr 03 '24 17:04 tofumatt