site-kit-wp icon indicating copy to clipboard operation
site-kit-wp copied to clipboard

Published 20 hours ago • verified publisher icon google

Implement the “no audiences” banner error state

Open techanvil opened this issue 1 year ago • 3 comments

Feature Description

Implement the error handling for the "no audiences" banner, showing the Full Width Error Banner when there is an error.

See no audiences banner > error state in the design doc.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

  • [ ]

Test Coverage

QA Brief

Changelog entry

techanvil avatar Jan 29 '24 14:01 techanvil

@techanvil it looks like this should be added to the design doc, right?

ivonac4 avatar Feb 02 '24 16:02 ivonac4

@ivonac4 yup this has been added to the design doc, I've created an additional issue in for the component and added that as a dependency here. This issue is now ready for AC.

techanvil avatar Feb 06 '24 10:02 techanvil

I've moved this back to Backlog as the final in-progress changes to the design doc, relating to audience caching, will probably affect the AC for this one.

I've also unassigned @jimmymadon from this one due to his break.

techanvil avatar Mar 28 '24 14:03 techanvil

The audience caching aspect of the design doc has been sufficiently finalised, and I've moved this back to AC.

techanvil avatar Apr 05 '24 14:04 techanvil