site-kit-wp icon indicating copy to clipboard operation
site-kit-wp copied to clipboard

Fix the <title> tag on the user input page.

Open Thakor-Yashpal opened this issue 2 years ago • 3 comments

Summary

Addresses issue:

Relevant technical choices

se

PR Author Checklist

  • [ ] My code is tested and passes existing unit tests.
  • [ ] My code has an appropriate set of unit tests which all pass.
  • [ ] My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • [ ] My code follows the WordPress coding standards.
  • [ ] My code has proper inline documentation.
  • [ ] I have added a QA Brief on the issue linked above.
  • [ ] I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • [ ] Run the code.
  • [ ] Ensure the acceptance criteria are satisfied.
  • [ ] Reassess the implementation with the IB.
  • [ ] Ensure no unrelated changes are included.
  • [ ] Ensure CI checks pass.
  • [ ] Check Storybook where applicable.
  • [ ] Ensure there is a QA Brief.

Merge Reviewer Checklist

  • [x] Ensure the PR has the correct target branch.
  • [ ] Double-check that the PR is okay to be merged.
  • [x] Ensure the corresponding issue has a ZenHub release assigned.
  • [ ] Add a changelog message to the issue.

Thakor-Yashpal avatar Oct 03 '22 10:10 Thakor-Yashpal

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Oct 03 '22 10:10 google-cla[bot]

z

Thakor-Yashpal avatar Oct 03 '22 10:10 Thakor-Yashpal

ok

Thakor-Yashpal avatar Oct 13 '22 01:10 Thakor-Yashpal

Closing as duplicate of https://github.com/google/site-kit-wp/pull/2883

aaemnnosttv avatar Jan 14 '23 22:01 aaemnnosttv

ok

Thakor-Yashpal avatar Jan 18 '23 07:01 Thakor-Yashpal