site-kit-wp icon indicating copy to clipboard operation
site-kit-wp copied to clipboard

Add more info as to what the 'Supporter wall' is in Settings

Open FlicHollis opened this issue 3 years ago • 6 comments

When I do not have the Supporter wall enabled, and I visit the Settings page, there is no explanatory text to advise what it is and why I should enable it. We do have that in the 'Supporter wall banner' but I suspect many people will click 'Maybe later' and forget about it, and then return to settings and have no incentive to add. Could we potentially add a 'i' icon to display a tooltip or something?

Supporter wall

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • On the TwG Settings view when no supporter wall widget is placed yet, add some explanatory text below the "Heading" and above the CTA: A supporter wall widget shows the list of people who supported your site using Thank with Google.
  • This should be visually similar to the related text in the settings edit view

Implementation Brief

  • Inside SettingsView.js -> https://github.com/google/site-kit-wp/blob/da8f2f9d312a71f0806888968fed60190a6d7bf9/assets/js/modules/thank-with-google/components/settings/SettingsView.js#L94-L105
  • Place new<p> with text from AC before the <p> above.
  • Add a new parent container (div or Fragment) as JSX expressions must have one parent element
  • Style <p> with text from AC to look similar as here -> https://github.com/google/site-kit-wp/blob/develop/assets/js/modules/thank-with-google/components/common/PositionRadio.js#L67

Test Coverage

VRT may need update

QA Brief

  • Ensure Thank with Google is set up on your site and that you have not yet added the supporter wall widget.
  • Open the Thank with Google settings UI
  • In the TwG settings wall view the new block with an info text should appear according to AC.
  • EG -> Screenshot 2022-10-10 at 17 32 44

Changelog entry

  • Add more context to the "Supporter Wall" setting in Thank with Google settings.

FlicHollis avatar Aug 25 '22 21:08 FlicHollis

@aaemnnosttv I added some copy for the Settings, do you think we should open a separate issue for adding a default title to the widget itself?

marrrmarrr avatar Sep 01 '22 12:09 marrrmarrr

Thanks @marrrmarrr – yes, I think we should tackle the changes to the widget separately. I'll open an issue for that 👍

As for the language, it reads well to me but "everyone" may be slightly inaccurate as I believe it only shows supporters who have chosen to support publicly, correct? That is, you can receive private contributions that wouldn't cause someone to show up on your wall, right? A minor detail but maybe worth clarifying here.

aaemnnosttv avatar Sep 02 '22 20:09 aaemnnosttv

Following up here – that issue for the default title was created here 👍

  • https://github.com/google/site-kit-wp/issues/5785

aaemnnosttv avatar Sep 12 '22 21:09 aaemnnosttv

Thanks @marrrmarrr – I tweaked the AC to be specific to the settings view here since the edit mode already has similar text.

aaemnnosttv avatar Sep 28 '22 19:09 aaemnnosttv

IB ✅

tofumatt avatar Oct 06 '22 20:10 tofumatt

QA Update ✅

  • Verified on dev.
  • Verified In the TwG settings wall view the new block with an info text appear according to AC.
  • When Supporter wall widget is added than info is not appearing under settings.

image

image

mohitwp avatar Oct 17 '22 07:10 mohitwp