Help menu not present on Analytics and Key Metrics setup screens

[techanvil]

Feature Description

When viewing the Analytics or Key Metrics setup screens in the new setup flow, the help menu is not present.

See related bug bash task in Asana.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• When viewing the Analytics or Key Metrics setup screens in the new setup flow, the help menu is present and behaves as per the AC for #11815.

Implementation Brief

• [ ] Update assets/js/components/key-metrics-setup/KeyMetricsSetupApp.js and assets/js/components/setup/ModuleSetup.js
  • [ ] Add the HelpMenu content to the children of Header, regardless of isInitialSetupFlow

Test Coverage

• Update the KeyMetricsSetupApp and ModuleSetup tests to ensure the HelpMenu is rendered.
• Update any failing snapshots/VRTs.

QA Brief

Changelog entry

[techanvil]

Hey @abdelmalekkkkk, this IB LGTM. With regard to the estimate, this looks like a "legit" 3, which means it should be bumped to a 7 according to our "bump to the next estimate" rule. Anything beyond a simple one-line change is generally regarded as a 3 (and thus bumped to a 7).

I'll increase the estimate myself to save a round trip.

IB ✅