shaderc icon indicating copy to clipboard operation
shaderc copied to clipboard

Support for combinedImageSamplers?

Open Makogan opened this issue 1 year ago • 1 comments

The microsoft compiler supports a special atribute for compatibility with glsl: https://github.com/microsoft/DirectXShaderCompiler/wiki/Vulkan-combined-image-sampler-type

However declaring this in an hlsl shader:

[[vk::combinedImageSampler]]
Texture2D<float4> textures[3] : register(t1);

And compiling with shaderc results in the error: examples/02_skinned_mesh/test.frag.hlsl:1: warning: 'combinedImageSampler' : unrecognized attribute

It would be a nice addition to shaderc I think. I would certainly find it very useful.

Makogan avatar Mar 07 '23 09:03 Makogan

This should be filed upstream in Glslang.

dneto0 avatar Mar 20 '23 20:03 dneto0