s2geometry

s2geometry copied to clipboard

I tried to enable the test workflow for ubuntu 22 and get a failure due to `sincos`. ``` /home/runner/work/s2geometry/s2geometry/src/s2/s1angle_test.cc:139: Failure Expected equality of these values: sin_cos.cos Which is: -0.2[58](https://github.com/google/s2geometry/actions/runs/13603572823/job/38032416706?pr=412#step:8:59)81904510251996 cos(angle)...

jmr

s2loop_measures_test GetSignedArea.ErrorAccumulation fails on macOS

1

Unclear if this is a problem with the allowed error threshold or the code. ``` [ RUN ] GetSignedArea.ErrorAccumulation .../s2geometry/src/s2/s2loop_measures_test.cc:286: Failure The difference between expected_area and actual_area is 3.5813685350660762e-11, which...

jmr

Swig error: Syntax error in input(3) with swig < 4.2

9

I was able to build successfully on master on the docker image `quay.io/pypa/manylinux_2_28_x86_64` (CentOS/Alma/RHEL 8 based), but image `python:3.13` (Debian based) errors on one of the swig steps. Reverting to...

andyneff

Use `cibuildwheel` for Python CI

1

I'd recommend using `cibuildwheel` for that but you're right, out of scope of this PR _Originally posted by @zacharyburnett in https://github.com/google/s2geometry/pull/388#discussion_r1828232233_

jmr