s2geometry icon indicating copy to clipboard operation
s2geometry copied to clipboard

modernize cmake

Open ObiWahn opened this issue 7 years ago • 3 comments

Please take a look at the current changes and let me know if they are something you like. If so I'll continue to work on my branch. This PR should eventually fix #35 #11 and maybe #6

ObiWahn avatar May 28 '18 18:05 ObiWahn

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

googlebot avatar May 28 '18 18:05 googlebot

I signed it!

ObiWahn avatar May 28 '18 20:05 ObiWahn

CLAs look good, thanks!

googlebot avatar May 28 '18 20:05 googlebot