s2geometry icon indicating copy to clipboard operation
s2geometry copied to clipboard

Add support for find_packge?

Open HolyMiss opened this issue 4 years ago • 2 comments

S2_USE_GLOG is invalid after install

HolyMiss avatar Jun 02 '21 09:06 HolyMiss

What do you mean by "invalid"? It looks like you just need to keep building with -DS2_USE_GLOG if you want to use glog.

How should we use find_package to make this better?

jmr avatar Sep 06 '21 12:09 jmr

I add S2_USE_GLOG when compiling. After I make install, if I do not add S2_USE_GLOG in my code, it will report an error. If I add this macro, it will be injected into my code, so a better way is to provide find_package Mode, Add the S2_USE_GLOG macro in S2Config.cmake if it is used during compilation

HolyMiss avatar Nov 03 '21 11:11 HolyMiss