re2j icon indicating copy to clipboard operation
re2j copied to clipboard

Add Automatic-Module-Name field to META-INF/MANIFEST.MF

Open UnaiUribarri-TomTom opened this issue 5 months ago • 2 comments

Add an Automatic-Module-Name to make the package module friendly, allowing its use in modularised applications in Java 9+.

Partially resolves issue #176

UnaiUribarri-TomTom avatar Jul 28 '25 15:07 UnaiUribarri-TomTom

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jul 28 '25 15:07 google-cla[bot]

@sjamesr thanks for maintaining this library. Is there a path to accepting this PR, or to publish as an mjar with a real module-info.java? It would make adoption much simpler.

Please LMK if I can help.

BTW this is how I have wired up module support in jsoup so that re2j works if folks are executing with modules enabled: https://github.com/jhy/jsoup/pull/2407/commits/d54e954794286528a26eb3e9148e1961b6bbd308 (PR)

jhy avatar Sep 25 '25 04:09 jhy