python-fire icon indicating copy to clipboard operation
python-fire copied to clipboard

Fix #300 typed arguments

Open loynoir opened this issue 3 years ago • 7 comments

Goal

[x] Solve issue300 [x] Let python-fire respect function's type annotations, and cast arguments into right types. [x] Solve issue64

Status

  1. If exists annotation, simple type (str, int, float) arguments are casted correctly now.
  2. iln-sk add datetime and pathlib typed.
  3. completion zsh compactible.

Now support

def hello(self, x: str, y: int, z: float):
    assert type(x) == str
    assert type(y) == int
    assert type(z) == float

Not Support

Custom types in annotations.

loynoir avatar Feb 16 '21 14:02 loynoir

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Feb 16 '21 14:02 google-cla[bot]

@googlebot I signed it!

loynoir avatar Feb 18 '21 11:02 loynoir

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Apr 12 '21 03:04 google-cla[bot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar May 05 '21 04:05 google-cla[bot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar May 14 '21 22:05 google-cla[bot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar May 14 '21 22:05 google-cla[bot]

This would be super useful. Right now we need to specify a lot of decorators to provide similar functionality, because very often our arguments looks like integers, and they are converted to int automagically, which triggers code later to fail (i.e. because it tries to use regexp on it, or concat with other string, etc).

Another good feature would be ability to disable automatic type detection also for kwargs, if it is typed, i.e. Dict[str, str].

baryluk avatar Aug 16 '21 12:08 baryluk