python-fire icon indicating copy to clipboard operation
python-fire copied to clipboard

Fix #317 Help text short args

Open ConorSheehan1 opened this issue 4 years ago • 6 comments

Closes #317

ConorSheehan1 avatar Feb 06 '21 00:02 ConorSheehan1

Thanks for the PR!

dbieber avatar Feb 06 '21 23:02 dbieber

Hey @dbieber no worries, I use fire for a few projects so I'd love to contribute back!

Also, I noticed the github action on my fork was failing because it couldn't find python 3.4 https://github.com/ConorSheehan1/python-fire/runs/1842567364?check_suite_focus=true

Version 3.4 was not found in the local cache
Error: Version 3.4 with arch x64 not found
The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

Only way I could get the build working was by removing 3.4, but I didn't include that in the pr. Happy to add it in though if you think it's needed?

Also checked locally that my branch still passes on 3.4. py-3 4 10-fire-crop

ConorSheehan1 avatar Feb 10 '21 21:02 ConorSheehan1

I've removed 3.4 from the CI now. Would be nice to add it back in if we can do so properly, but it's certainly not a priority.

dbieber avatar Apr 16 '22 21:04 dbieber

@dbieber cool, is there anything left I should change or is this ok to merge now?

ConorSheehan1 avatar Apr 16 '22 21:04 ConorSheehan1

I'll do some cleanup when I merge it but unfortunately I won't get to that today.

I'm also not sure why the CI tests didn't run on this PR...

dbieber avatar Apr 16 '22 22:04 dbieber

Cool no rush. Not sure about the CI either tbh, can you trigger it manually? Or can I do something on my end?

ConorSheehan1 avatar Apr 16 '22 22:04 ConorSheehan1

Thanks for your patience. At long last, I've merged your PR and we'll include it in the next release.

dbieber avatar Dec 09 '22 20:12 dbieber

Thanks so much for following up! Really appreciate it

ConorSheehan1 avatar Dec 10 '22 19:12 ConorSheehan1