Add new symbol directory layout by build-id `/xx/xxxxxxxx.debug`.
This protocol is already supported by various tools and lldb. e.g.: https://github.com/llvm-mirror/lldb/blob/d01083a850f577b85501a0902b52fd0930de72c7/source/Symbol/LocateSymbolFile.cpp#L311
Among others it is used by Fuchisa OS builds.
This change was unit tested with fetch_test.go.
It was manually tested with a FuchsaOS build by pointing pprof at $FUCHSIA_HOME/out/default/.build-id
Codecov Report
Merging #724 (2d56bd5) into main (70bd9ae) will increase coverage by
0.00%. The diff coverage isn/a.
:exclamation: Current head 2d56bd5 differs from pull request most recent head 314f5ea. Consider uploading reports for the commit 314f5ea to get more accurate results
@@ Coverage Diff @@
## main #724 +/- ##
=======================================
Coverage 64.67% 64.68%
=======================================
Files 45 45
Lines 6602 6603 +1
=======================================
+ Hits 4270 4271 +1
Misses 1884 1884
Partials 448 448
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...c/github.com/google/pprof/internal/driver/fetch.go | 63.01% <0.00%> (+0.12%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@piwicode CI fails due to wrong source code formatting.
This should be fine now. Thanks.