pprof icon indicating copy to clipboard operation
pprof copied to clipboard

Print better messages for problems with tag filtering ranges

Open nolanmar511 opened this issue 7 years ago • 5 comments

Right now, 0B:256B is interpreted at a range for filtering tags, but 0:256B is not.

I think we should either infer that the units are the same for both parts of the range if units are only specified for one half of the range, or not require units for zero.

nolanmar511 avatar Nov 21 '18 20:11 nolanmar511

We should also, perhaps, provide a message to indicate when something that looks like a range is being interpreted as a regexp.

nolanmar511 avatar Nov 21 '18 20:11 nolanmar511

I think complaining with a clear error message that units are different here would be sufficient to guide the user.

aalexand avatar Nov 21 '18 20:11 aalexand

Make sense to me.

User originally started with "0:256" -- so perhaps we should also complain when there are no units.

nolanmar511 avatar Nov 21 '18 20:11 nolanmar511

"0:256" is in count units I think.

aalexand avatar Nov 21 '18 20:11 aalexand

For "0:256" I'd expect an error message that tag X has the unit of Y but unit Z was used in the filter.

aalexand avatar Nov 21 '18 20:11 aalexand